Skip to content

In File Create/Update API return 404 if Branch does not exist #11791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 2 commits into from
Jun 7, 2020
Merged

In File Create/Update API return 404 if Branch does not exist #11791

zeripath merged 2 commits into from
Jun 7, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Jun 7, 2020

close #10982

@6543 6543 changed the title API: File Create/Update detect if Branch not exist [BugFix] [API] File Create/Update detect if Branch not exist Jun 7, 2020
@zeripath
Copy link
Contributor

zeripath commented Jun 7, 2020

make lg-tm work

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 7, 2020
@zeripath zeripath changed the title [BugFix] [API] File Create/Update detect if Branch not exist In File Create/Update API return 404 if Branch does not exist Jun 7, 2020
@6543
Copy link
Member Author

6543 commented Jun 7, 2020

Ping lgtm

@zeripath zeripath merged commit 479ef5c into go-gitea:master Jun 7, 2020
@zeripath
Copy link
Contributor

zeripath commented Jun 7, 2020

ʇɹodʞɔɐq puǝs ǝsɐǝlԀ

@6543 6543 deleted the api-fix-repoCreateFile-500_10982 branch June 7, 2020 18:37
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 7, 2020
@6543
In File Create/Update API return 404 if Branch does not exist (go-git…
ea05d18 
…ea#11791)
@6543 6543 mentioned this pull request Jun 7, 2020
Merged
@6543
Copy link
Member Author

6543 commented Jun 7, 2020

-> #11795

@lafriks lafriks added the backport/done All backports for this PR have been created label Jun 7, 2020
lafriks pushed a commit that referenced this pull request Jun 7, 2020
@6543
In File Create/Update API return 404 if Branch does not exist (#11791) (
20951c5 
#11795)

* In File Create/Update API return 404 if Branch does not exist (#11791)

* v1.12 version ;)
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
In File Create/Update API return 404 if Branch does not exist (go-git…
5b06f90 
…ea#11791)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

[Bug] [API] repoCreateFile return 500 if branch not exist

4 participants

@6543 @zeripath @lafriks @GiteaBot