Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 19, 2020

Fix #13979

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 19, 2020
@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #14064 (7c10d6a) into master (4ef7512) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14064      +/-   ##
==========================================
- Coverage   42.32%   42.32%   -0.01%     
==========================================
  Files         726      726              
  Lines       77684    77679       -5     
==========================================
- Hits        32883    32875       -8     
- Misses      39403    39406       +3     
  Partials     5398     5398              
Impacted Files Coverage Δ
models/action.go 50.00% <0.00%> (-0.72%) ⬇️
modules/git/repo_tag.go 59.54% <75.00%> (+0.84%) ⬆️
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (ø)
models/error.go 38.98% <0.00%> (+0.48%) ⬆️
services/pull/pull.go 41.87% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e674478...7c10d6a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2020
Copy link
Contributor

@CirnoT CirnoT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also instance on
{{$.i18n.Tr "action.delete_tag" .GetRepoLink (.GetBranch|Escape) .ShortRepoPath | Str2html}}

@lunny
Copy link
Member Author

lunny commented Dec 19, 2020

action.delete_tag

Done.

@lafriks lafriks added this to the 1.14.0 milestone Dec 19, 2020
@lunny lunny merged commit 36bd5d7 into go-gitea:master Dec 19, 2020
@lunny lunny deleted the lunny/fix_feed_push_tag branch December 19, 2020 23:46
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 error when opening a branch on the dashboard

7 participants