Skip to content

fix branch selector on new issue page #14194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 3 commits into from
Dec 31, 2020
Merged

fix branch selector on new issue page #14194

techknowlogick merged 3 commits into from
Dec 31, 2020

Conversation

@a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Dec 30, 2020

fix #14185

@codecov-io
Copy link

codecov-io commented Dec 30, 2020 •
edited
Loading

Codecov Report

Merging #14194 (fb23deb) into master (ef825bd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14194      +/-   ##
==========================================
+ Coverage   42.01%   42.02%   +0.01%     
==========================================
  Files         733      733              
  Lines       78715    78715              
==========================================
+ Hits        33070    33079       +9     
+ Misses      40213    40204       -9     
  Partials     5432     5432
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (-12.00%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-6.39%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
services/pull/pull.go 42.35% <0.00%> (ø)
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
services/gitdiff/gitdiff.go 70.93% <0.00%> (+1.93%) ⬆️
modules/charset/charset.go 75.28% <0.00%> (+6.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef825bd...fb23deb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2020
@lunny lunny added the type/bug label Dec 30, 2020
@lunny lunny added this to the 1.14.0 milestone Dec 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2020
@techknowlogick techknowlogick merged commit b003116 into go-gitea:master Dec 31, 2020
@lunny
Copy link
Member

lunny commented Jan 1, 2021

Please send backport to v1.13

@a1012112796 a1012112796 deleted the fix_branch_selector branch January 1, 2021 08:52
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 1, 2021
@a1012112796 @lunny
fix branch selector on new issue page (go-gitea#14194)
c3767b1 
fix go-gitea#14185

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
@a1012112796 a1012112796 mentioned this pull request Jan 1, 2021
Merged
@a1012112796 a1012112796 added the backport/done All backports for this PR have been created label Jan 1, 2021
lafriks pushed a commit that referenced this pull request Jan 1, 2021
@a1012112796 @lunny
fix branch selector on new issue page (#14194) (#14207)
5568dd6 
fix #14185

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Cannot choose branch when creating issue

6 participants

@a1012112796 @codecov-io @lunny @zeripath @techknowlogick @GiteaBot