Skip to content

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 9, 2021

make test#TestTotal_RenderWiki and make test#TestTotal_RenderString failed if run individually. They worked with make test because other tests updated the settings beforehand.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15802 (fd0c4ed) into main (a98c09d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15802      +/-   ##
==========================================
- Coverage   43.98%   43.97%   -0.01%     
==========================================
  Files         678      678              
  Lines       82024    82024              
==========================================
- Hits        36076    36072       -4     
- Misses      40073    40077       +4     
  Partials     5875     5875              
Impacted Files Coverage Δ
modules/queue/queue_bytefifo.go 81.20% <0.00%> (-2.02%) ⬇️
modules/queue/workerpool.go 51.64% <0.00%> (-1.10%) ⬇️
models/gpg_key.go 53.51% <0.00%> (-0.57%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98c09d...fd0c4ed. Read the comment docs.

@6543 6543 merged commit e818e91 into go-gitea:main May 9, 2021
@KN4CK3R KN4CK3R deleted the fix-markdown-test branch May 11, 2021 07:06
techknowlogick added a commit that referenced this pull request May 12, 2021
* Decouple TestAction_GetRepoLink and TestSizedAvatarLink.

* Load database for TestCheckGPGUserEmail.

* Load database for TestMakeIDsFromAPIAssigneesToAdd.

* Load database for TestGetUserIDsByNames and TestGetMaileableUsersByIDs.

* Load database for TestUser_ToUser.

* Load database for TestRepository_EditWikiPage.

* Include AppSubURL in test.

* Prevent panic with empty slice.

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Decouple TestAction_GetRepoLink and TestSizedAvatarLink.

* Load database for TestCheckGPGUserEmail.

* Load database for TestMakeIDsFromAPIAssigneesToAdd.

* Load database for TestGetUserIDsByNames and TestGetMaileableUsersByIDs.

* Load database for TestUser_ToUser.

* Load database for TestRepository_EditWikiPage.

* Include AppSubURL in test.

* Prevent panic with empty slice.

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants