Swagger API: rename repoAddTopíc to repoAddTopic #16580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the operationId to only contain 7 bit ascii, note "í" instead of "i"
This comment has been minimized.
This comment has been minimized.
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Jul 31, 2021
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Aug 1, 2021
GiteaBot
added
lgtm/done
Contributor
Author
|
After main was merged into the branch, the build fails with "TypeError: String.prototype.startsWith called on null or undefined" This is also a problem in other PRs, so I guess there is something wrong in main? |
Member
|
@larshp indeed, your PR is correct. We need to resolve an unrelated issue before being able to merge your PR. Thank you for your work on this PR. |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Swagger API: rename repoAddTopíc to repoAddTopic This changes the operationId to only contain 7 bit ascii, note "í" instead of "i"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
operationIdof operation "repoAddTopic" to only contain 7-bit ascii, note "i" instead of "í"