Skip to content

Conversation

@zeripath
Copy link
Contributor

Unfortunately there is bug in #16544 meaning that openid connects aren't
being matched properly as the capitalisation in that PR is incorrect.

This PR changes the capitalisation back to what is expected.

Signed-off-by: Andrew Thornton [email protected]

Unfortunately there is bug in go-gitea#16544 meaning that openid connects aren't
being matched properly as the capitalisation in that PR is incorrect.

This PR changes the capitalisation back to what is expected.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 20, 2021
@zeripath zeripath added this to the 1.16.0 milestone Aug 20, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #16759 (3171c5c) into main (cee5f7c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16759      +/-   ##
==========================================
+ Coverage   45.49%   45.51%   +0.01%     
==========================================
  Files         762      762              
  Lines       85939    85939              
==========================================
+ Hits        39099    39115      +16     
+ Misses      40527    40516      -11     
+ Partials     6313     6308       -5     
Impacted Files Coverage Δ
services/auth/source/oauth2/providers_openid.go 53.33% <100.00%> (ø)
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/queue/workerpool.go 55.72% <0.00%> (+1.90%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208ae9e...3171c5c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2021
@zeripath zeripath merged commit 7f85610 into go-gitea:main Aug 22, 2021
@zeripath zeripath deleted the fix-regression-in-16544-openidconnect branch August 22, 2021 09:17
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants