Skip to content

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 27, 2021

Close #17443

Maybe we do not need to backport this PR, the bug doesn't break daily usage. OK, we backport.

After the fix, the commit statuses popup can show a lot of lines with scroll bars:

image

@wxiaoguang wxiaoguang force-pushed the fix-commit-statuses-popup branch from 3230b65 to 859495d Compare October 27, 2021 08:16
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 27, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Oct 27, 2021
@wxiaoguang wxiaoguang force-pushed the fix-commit-statuses-popup branch from 859495d to ed258d0 Compare October 27, 2021 08:23
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 27, 2021
@lunny
Copy link
Member

lunny commented Oct 27, 2021

I think it's better to backport since v1.16 hasn't been released.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2021
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 2b2eb5d into go-gitea:main Oct 28, 2021
@zeripath
Copy link
Contributor

Please send backport

@wxiaoguang wxiaoguang deleted the fix-commit-statuses-popup branch October 28, 2021 03:28
@lunny lunny added the backport/done All backports for this PR have been created label Oct 28, 2021
@zeripath zeripath changed the title Make commit-statuses popup can be shown correctly. Make commit-statuses popup show correctly. Oct 28, 2021
@zeripath zeripath mentioned this pull request Oct 28, 2021
zeripath pushed a commit that referenced this pull request Oct 28, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 28, 2021
Frontport go-gitea#17457

 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28

* BUGFIXES
  * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435)
  * Fix CSV render error (go-gitea#17406) (go-gitea#17431)
  * Read expected buffer size (go-gitea#17409) (go-gitea#17430)
  * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464)
  * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466)
* TESTING
  * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
zeripath added a commit that referenced this pull request Oct 28, 2021
Frontport #17457

 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28

* BUGFIXES
  * Prevent panic in serv.go with Deploy Keys (#17434) (#17435)
  * Fix CSV render error (#17406) (#17431)
  * Read expected buffer size (#17409) (#17430)
  * Ensure that restricted users can access repos for which they are members (#17460) (#17464)
  * Make commit-statuses popup show correctly (#17447) (#17466)
* TESTING
  * Add integration tests for private.NoServCommand and private.ServCommand (#17456) (#17463)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Close go-gitea#17443

Maybe we do not need to backport this PR, the bug doesn't break daily usage.

After the fix, the commit statuses popup can show a lot of lines with scroll bars:

![image](https://user-images.githubusercontent.com/2114189/139026160-f01b484c-6207-494a-a190-a6dd184ceb2b.png)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Frontport go-gitea#17457

 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28

* BUGFIXES
  * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435)
  * Fix CSV render error (go-gitea#17406) (go-gitea#17431)
  * Read expected buffer size (go-gitea#17409) (go-gitea#17430)
  * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464)
  * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466)
* TESTING
  * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit Statuses popup to large to open with 21 statuses

5 participants