Quote the table name in CountOrphanedObjects #17487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountOrphanedObjects needs to quote the table it is joining with as this table may be `user`. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 29, 2021
Backport go-gitea#17487 CountOrphanedObjects needs to quote the table it is joining with as this table may be `user`. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
silverwind
approved these changes
Oct 29, 2021
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #17487 +/- ##
=======================================
Coverage 45.48% 45.49%
=======================================
Files 791 791
Lines 88702 88702
=======================================
+ Hits 40350 40355 +5
+ Misses 41841 41830 -11
- Partials 6511 6517 +6
Continue to review full report at Codecov.
|
lunny
approved these changes
Oct 30, 2021
GiteaBot
added
lgtm/done
Contributor
Author
|
make lgtm work |
6543
pushed a commit
that referenced
this pull request
Oct 30, 2021
Backport #17487 CountOrphanedObjects needs to quote the table it is joining with as this table may be `user`. Fix #17485 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 22, 2021
Although go-gitea#17487 ensured that the table was quoted in the join it missed that the query part of the check also needed to be quoted. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 22, 2021
) Backport go-gitea#18072 Although go-gitea#17487 ensured that the table was quoted in the join it missed that the query part of the check also needed to be quoted. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
Dec 22, 2021
…8073) Backport #18072 Although #17487 ensured that the table was quoted in the join it missed that the query part of the check also needed to be quoted. Fix #17485 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
Dec 22, 2021
Although #17487 ensured that the table was quoted in the join it missed that the query part of the check also needed to be quoted. Fix #17485 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
CountOrphanedObjects needs to quote the table it is joining with as this table may be `user`. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
) Although go-gitea#17487 ensured that the table was quoted in the join it missed that the query part of the check also needed to be quoted. Fix go-gitea#17485 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CountOrphanedObjects needs to quote the table it is joining with as this table may
be
user.Fix #17485
Signed-off-by: Andrew Thornton [email protected]