Skip to content

Use exec -a in the FHS compliant script #17513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 3 commits into from
Nov 3, 2021
Merged

Use exec -a in the FHS compliant script #17513

techknowlogick merged 3 commits into from
Nov 3, 2021

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Nov 1, 2021

If we exec gitea using an explicit exec -a we can set the name of the binary
to the script's name thus ensuring all written calls by gitea will go via
the script.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Use exec -a in the FHS compliant script
4793fe3 
If we exec gitea using an explicit `exec -a` we can set the name of the binary
to the script's name thus ensuring all written calls by gitea will go via
the script.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 1, 2021
@zeripath zeripath added this to the 1.16.0 milestone Nov 1, 2021
@zeripath zeripath mentioned this pull request Nov 1, 2021
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@118fbd9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17513   +/-   ##
=======================================
  Coverage        ?   45.48%           
=======================================
  Files           ?      793           
  Lines           ?    88793           
  Branches        ?        0           
=======================================
  Hits            ?    40390           
  Misses          ?    41893           
  Partials        ?     6510

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118fbd9...5284383. Read the comment docs.

@techknowlogick techknowlogick merged commit a5bcf19 into go-gitea:main Nov 3, 2021
@zeripath zeripath deleted the fhs-compliant-script-exec-a branch November 5, 2021 15:30
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath
Use exec -a in the FHS compliant script (go-gitea#17513)
85f18b4
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@zeripath @codecov-commenter @techknowlogick @lafriks @GiteaBot @lunny