Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 3, 2022

For some users who have know the risk, this PR allows to disable all renderer sanitize. The default value is still keeping compatible.

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 3, 2022
@lunny lunny added this to the 1.17.0 milestone Mar 3, 2022
@silverwind
Copy link
Member

Need to update docs?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2022
@lunny lunny force-pushed the lunny/support_disable_santized branch from 9a6dd19 to 9dec47c Compare March 3, 2022 12:32
@lunny
Copy link
Member Author

lunny commented Mar 3, 2022

Need to update docs?

Done.

@codecov-commenter
Copy link

Codecov Report

Merging #18984 (9dec47c) into main (548adb9) will decrease coverage by 0.02%.
The diff coverage is 34.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18984      +/-   ##
==========================================
- Coverage   46.62%   46.60%   -0.03%     
==========================================
  Files         854      854              
  Lines      122587   122835     +248     
==========================================
+ Hits        57153    57244      +91     
- Misses      58537    58672     +135     
- Partials     6897     6919      +22     
Impacted Files Coverage Δ
models/issue_comment.go 51.98% <0.00%> (+0.56%) ⬆️
models/user/search.go 69.38% <ø> (ø)
modules/markup/csv/csv.go 28.28% <0.00%> (-0.59%) ⬇️
modules/markup/external/external.go 1.35% <0.00%> (-0.04%) ⬇️
modules/markup/orgmode/orgmode.go 51.88% <0.00%> (-1.00%) ⬇️
modules/nosql/manager_leveldb.go 0.00% <0.00%> (ø)
modules/notification/base/null.go 84.61% <0.00%> (-2.23%) ⬇️
modules/notification/notification.go 92.63% <0.00%> (-2.34%) ⬇️
modules/setting/markup.go 5.61% <0.00%> (-0.07%) ⬇️
routers/api/v1/repo/issue.go 54.45% <0.00%> (-2.96%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddd2fb...9dec47c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2022
@lunny
Copy link
Member Author

lunny commented Mar 6, 2022

make L-G-T-M work.

@lunny lunny merged commit b24e8d3 into go-gitea:main Mar 6, 2022
@lunny lunny deleted the lunny/support_disable_santized branch March 6, 2022 08:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 7, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add Index to comment for migrations and mirroring (go-gitea#18806)
  Support ignore all santize for external renderer (go-gitea#18984)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Support ignore all santize for external renderer

* Update docs

* Apply suggestions from code review

Co-authored-by: silverwind <[email protected]>

* Fix doc

Co-authored-by: silverwind <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants