Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 31, 2022

No description provided.

@lunny lunny added pr/wip This PR is not ready for review type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Mar 31, 2022
@lunny lunny force-pushed the lunny/model_milestone branch 2 times, most recently from 62a32e3 to d2103d3 Compare April 5, 2022 02:15
@codecov-commenter
Copy link

Codecov Report

Merging #19278 (d2103d3) into main (d242511) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main   #19278      +/-   ##
==========================================
- Coverage   47.51%   47.48%   -0.03%     
==========================================
  Files         944      944              
  Lines      131549   131538      -11     
==========================================
- Hits        62500    62462      -38     
- Misses      61541    61581      +40     
+ Partials     7508     7495      -13     
Impacted Files Coverage Δ
models/action.go 48.61% <0.00%> (ø)
models/error.go 36.46% <ø> (-0.03%) ⬇️
models/issue_label.go 68.02% <0.00%> (ø)
models/issue_lock.go 0.00% <0.00%> (ø)
models/issue_project.go 31.70% <0.00%> (ø)
models/pull.go 55.81% <0.00%> (ø)
models/statistic.go 0.00% <0.00%> (ø)
modules/convert/pull.go 60.00% <0.00%> (ø)
modules/notification/action/action.go 67.04% <0.00%> (ø)
modules/notification/mail/mail.go 41.78% <0.00%> (+2.73%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae875a...d2103d3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2022
@lunny lunny removed the pr/wip This PR is not ready for review label Apr 5, 2022
@lunny lunny added this to the 1.17.0 milestone Apr 5, 2022
@lunny lunny requested review from 6543 and wxiaoguang April 8, 2022 01:43
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2022
@lunny lunny force-pushed the lunny/model_milestone branch from 330d856 to 60b58e8 Compare April 8, 2022 07:13
@lunny
Copy link
Member Author

lunny commented Apr 8, 2022

make L-G-T-M work.

@lunny lunny merged commit 1dfa26e into go-gitea:main Apr 8, 2022
@lunny lunny deleted the lunny/model_milestone branch April 8, 2022 09:11
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 11, 2022
* giteaofficial/main: (22 commits)
  Add logic to switch between source/rendered on Markdown (go-gitea#19356)
  Fixed registry host value. (go-gitea#19363)
  [skip ci] Updated translations via Crowdin
  Allow package linking to private repository (go-gitea#19348)
  Use "main" as default branch name (go-gitea#19354)
  Move milestone to models/issues/ (go-gitea#19278)
  Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (go-gitea#19337)
  Remove dependent on session auth for api/v1 routers (go-gitea#19321)
  API: Search Issues, dont show 500 if filter result in empty list (go-gitea#19244)
  [skip ci] Updated translations via Crowdin
  Never use /api/v1 from Gitea UI Pages (go-gitea#19318)
  [skip ci] Updated translations via Crowdin
  Show ssh command directly in template instead of i18n translation (go-gitea#19335)
  Package registry changes (go-gitea#19305)
  [skip ci] Updated translations via Crowdin
  Add `ENABLE_SSH_LOG` to debugging problems (go-gitea#19316)
  Warn on SSH connection for incorrect configuration (go-gitea#19317)
  escape fake link
  Allow custom redirect for landing page (go-gitea#19324)
  [skip ci] Updated translations via Crowdin
  ...
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Move milestone to models/issues/

* Fix lint

* Fix test

* Fix lint

* Fix lint
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants