Skip to content

Use correct context in routers/web #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 1 commit into from
May 3, 2022
Merged

Use correct context in routers/web #19597

6543 merged 1 commit into from
May 3, 2022

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented May 3, 2022

Use correct context in routers/web
6deb978 
- Don't use the `APIContext` in the web routers.
@Gusted Gusted added this to the 1.17.0 milestone May 3, 2022
@Gusted Gusted added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed type/bug labels May 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 3, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2022
@6543 6543 merged commit cc3016f into go-gitea:main May 3, 2022
@Gusted Gusted deleted the fix-incorrect-context branch May 3, 2022 21:39
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 4, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5b8948d 
* giteaofficial/main:
  Fix broken TR on cherrypick page (go-gitea#19599)
  Use correct context in `routers/web` (go-gitea#19597)
  Use for a repo action one database transaction (go-gitea#19576)
  Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (go-gitea#19581)
  Don't fetch Mirror when it's migrating (go-gitea#19588)
  Move user password verification after checking his groups on ldap auth (go-gitea#19587)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Use correct context in routers/web (go-gitea#19597)
28a39d9 
- Don't use the `APIContext` in the web routers.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Gusted @6543 @delvh @GiteaBot