Fixing wrong paging when filtering on the issue dashboard #19801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19801 +/- ##
=======================================
Coverage ? 47.27%
=======================================
Files ? 958
Lines ? 133506
Branches ? 0
=======================================
Hits ? 63114
Misses ? 62725
Partials ? 7667
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
May 25, 2022
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
May 25, 2022
GiteaBot
added
lgtm/done
Member
|
please update branch or allow maintainers to edit |
Mai-Lapyst
force-pushed
the
fix-wrong-issue-counting-for-pageing-on-issue-dashboard
branch
from
bd17cab to
223afc4
Compare
Contributor
Author
Have rebased; you also should now be able to edit the branch if further rebasing is necessary |
zeripath
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 5, 2022
* giteaofficial/main: Add alt text to logo (go-gitea#19892) Limit max-height of CodeMirror editors for issue comment and wiki (go-gitea#18271) Implement http signatures support for the API (go-gitea#17565) Increment tests time out from 40m to 50m because sometimes the machine is slow (go-gitea#19887) fix(CI/CD): correct CI variable. (go-gitea#19886) Fix typo (go-gitea#19889) Fixing wrong paging when filtering on the issue dashboard (go-gitea#19801) Move `/info` outside authorization (go-gitea#19888) Fix order by parameter (go-gitea#19849) Exclude Archived repos from Dashboard Milestones (go-gitea#19882) use exact search instead of fuzzy search for branch filter dropdown (go-gitea#19885)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…9801) Fixes go-gitea#19791 by adding an check if filtering after any repo; if yes, simply set the total count for the pageing to the sum of the issue count for each selected repo by utilize `issueCountByRepo`. Fix go-gitea#19791
Mai-Lapyst
deleted the
fix-wrong-issue-counting-for-pageing-on-issue-dashboard
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19791 by adding an check if filtering after any repo; if yes, simply set the total count for the pageing to the sum of the issue count for each selected repo by utilize
issueCountByRepo.Fix #19791