Skip to content

Refactor session close as xorm already does everything needed internally #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Jun 21, 2017
Merged

Refactor session close as xorm already does everything needed internally #2020

lunny merged 1 commit into from
Jun 21, 2017

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Jun 20, 2017

@ethantkoenig
Copy link
Member

ethantkoenig commented Jun 20, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 20, 2017
@lunny
Copy link
Member

lunny commented Jun 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 21, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 21, 2017
@lunny lunny merged commit 6db387a into go-gitea:master Jun 21, 2017
@lafriks lafriks deleted the refactor_session_close branch June 21, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lafriks @ethantkoenig @lunny @tboerger