Skip to content

Include go.mod in gomod-check and rename to tidy-check #21025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Sep 2, 2022
Merged

Include go.mod in gomod-check and rename to tidy-check #21025

lunny merged 2 commits into from
Sep 2, 2022

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Sep 1, 2022 •
edited
Loading

  • go mod tidy can introduce changes in go.mod, add it to the diffing
  • Rename gomod-check to tidy-check as I think it's a more fitting name

@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 1, 2022
@silverwind silverwind added this to the 1.18.0 milestone Sep 1, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 1, 2022
@techknowlogick techknowlogick added topic/code-linting and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 1, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Sep 1, 2022
@lunny
Copy link
Member

lunny commented Sep 2, 2022

make L-G-T-M work

@lunny lunny merged commit b7a4b45 into go-gitea:main Sep 2, 2022
@silverwind silverwind deleted the tidycheck branch September 2, 2022 06:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
d823577 
* upstream/main:
  Include go.mod in gomod-check and rename to tidy-check (go-gitea#21025)
  [skip ci] Updated translations via Crowdin
  Update a few go dependencies (go-gitea#21022)
  [skip ci] Updated translations via Crowdin
  Fix missed sort bug (go-gitea#20996)
  Fix typo (go-gitea#21004)
  Make sure fmt catches all templates (go-gitea#20979)
  Remove black labels and CSS cleanup (go-gitea#21003)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @lunny @techknowlogick @jolheiser @GiteaBot