Use Go 1.19 fmt for Gitea 1.17, sync emoji data #21239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
topic/build
KN4CK3R
approved these changes
Sep 22, 2022
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Sep 22, 2022
| // Copyright 2020 The Gitea Authors. All rights reserved. | ||
| // Use of this source code is governed by a MIT-style | ||
| // license that can be found in the LICENSE file. | ||
Member
There was a problem hiding this comment.
The 2020 three lines above is now outdated
Member
There was a problem hiding this comment.
But we should probably fix this on main rather then on this branch.
Contributor
Author
There was a problem hiding this comment.
Yup, this is only a backport
GiteaBot
added
lgtm/done
wxiaoguang
changed the title
Contributor
Author
|
The emoji-data is also synchronized from main branch (by the backport part), I think it's fine to get it in 1.17. If there are some worries, we can revert it later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the images used by Gitea's drone pipeline were upgraded to Go 1.19.x
It causes the lint fails because Go 1.19 uses new code format.
This PR partially backport #20758 (including the emoji-data sync), partially fix the format manually.