Skip to content

Use different SVG for pending and running actions #23836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 4 commits into from
Mar 31, 2023
Merged

Use different SVG for pending and running actions #23836

lunny merged 4 commits into from
Mar 31, 2023

Conversation

@HesterG
Copy link
Contributor

@HesterG HesterG commented Mar 31, 2023

Before:
截屏2023-03-31 11 12 17
截屏2023-03-31 11 10 48

After:
截屏2023-03-31 11 05 44
截屏2023-03-31 11 06 56

@HesterG HesterG added the topic/ui Change the appearance of the Gitea UI label Mar 31, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2023
@wolfogre
Copy link
Member

wolfogre commented Mar 31, 2023 •
edited
Loading

CI failed because:

gitea/tests/integration/repo_commits_test.go

Line 113 in 3596df5

doTestRepoCommitWithStatus(t, "pending", "octicon-dot-fill", "yellow")

And maybe add missing TestRepoCommitsWithStatusRunning by the way

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023 •
edited
Loading

Codecov Report

Merging #23836 (2b76c9c) into main (f521e88) will decrease coverage by 0.14%.
The diff coverage is 28.92%.

@@            Coverage Diff             @@
##             main   #23836      +/-   ##
==========================================
- Coverage   47.14%   47.01%   -0.14%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153179    +1733     
==========================================
+ Hits        71397    72010     +613     
- Misses      71611    72666    +1055     
- Partials     8438     8503      +65
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 65 more

... and 66 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@delvh delvh added this to the 1.20.0 milestone Mar 31, 2023
@delvh delvh changed the title Change svg on commit status template to discriminate pending and running states Use different SVG for pending and running actions Mar 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2023
@lunny lunny merged commit 7df036f into go-gitea:main Mar 31, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
9ada9c1 
* giteaoffical/main:
  Fix 500 error if there is a name conflict when edit authentication source (go-gitea#23832)
  Use different SVG for pending and running actions (go-gitea#23836)
  CSS color tweaks (go-gitea#23828)
  Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons (go-gitea#23819)
@HesterG HesterG deleted the change-pending-icon branch April 10, 2023 02:28
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jolheiser jolheiser jolheiser approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

7 participants

@HesterG @wolfogre @codecov-commenter @jolheiser @delvh @lunny @GiteaBot