Skip to content

Support Azure Blob Storage #25458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yp05327 wants to merge 19 commits into from
Closed

Support Azure Blob Storage #25458

yp05327 wants to merge 19 commits into from

Conversation

@yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jun 23, 2023 •
edited
Loading

Try to support #22527

Using azure official SDK, add a new storage type: azureblob

This PR is working in process.

TODO:

  • CI Tests
    • integration test
    • unit test
  • Improve performance?
  • CLI Migrate Storage
  • docs?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2023
@yp05327 yp05327 marked this pull request as draft June 23, 2023 03:02
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 23, 2023

Why the MinIO SDK (which is a S3 client) doesn't work with Azure Blob Storage? Isn't Azure Blob Storage S3-compatible ?

@techknowlogick
Copy link
Member

techknowlogick commented Jun 23, 2023

Isn't Azure Blob Storage S3-compatible ?

no, it uses a different API. https://learn.microsoft.com/en-us/rest/api/storageservices/blob-service-rest-api

@yp05327 yp05327 force-pushed the azure-blob-storage-support branch from 7be0cba to 0a0c188 Compare June 23, 2023 04:18
KN4CK3R
KN4CK3R reviewed Jun 26, 2023
View reviewed changes
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 17, 2023

Download from direct URL uses 1mins, but download from Gitea uses 7mins. 😕

@yp05327 yp05327 force-pushed the azure-blob-storage-support branch from dafd3b3 to 3a3468a Compare November 20, 2023 07:40
@yp05327 yp05327 force-pushed the azure-blob-storage-support branch from 3a3468a to bc27561 Compare November 20, 2023 07:50
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 21, 2023 •
edited
Loading

Customizing Content-Disposition header was removed in the latest azure SDK.
Trying to fix it in Azure/azure-sdk-for-go#22024

Edited:
We should implement this by ourselves. 😕

@mirkoSekulic mirkoSekulic mentioned this pull request Nov 24, 2023
Closed
@yp05327 yp05327 changed the title [WIP] Support Azure Blob Storage Support Azure Blob Storage Nov 27, 2023
@yp05327 yp05327 marked this pull request as ready for review November 27, 2023 00:53
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2023
Closed
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 29, 2023

Would something like https://github.com/beyondstorage/go-storage help? It also helps GCP #26963

@yp05327
Copy link
Contributor Author

yp05327 commented Jan 15, 2024

Would something like https://github.com/beyondstorage/go-storage help? It also helps GCP #26963

It seems that no one is maintaining it now. Only the bot is alive. 🤔

@lunny lunny mentioned this pull request May 16, 2024
Merged
6 tasks
@yp05327
Copy link
Contributor Author

yp05327 commented May 16, 2024

replaced by #30995

@yp05327 yp05327 closed this May 16, 2024
lunny added a commit that referenced this pull request May 30, 2024
@lunny @yp05327
Azure blob storage support (#30995)
fb7b743 
This PR implemented object storages(LFS/Packages/Attachments and etc.)
for Azure Blob Storage. It depends on azure official golang SDK and can
support both the azure blob storage cloud service and azurite mock
server.

Replace #25458
Fix #22527 

- [x] CI Tests
- [x] integration test, MSSQL integration tests will now based on
azureblob
  - [x] unit test 
- [x] CLI Migrate Storage
- [x] Documentation for configuration added

------

TODO (other PRs):
- [ ] Improve performance of `blob download`.

---------

Co-authored-by: yp05327 <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2024
@yp05327 yp05327 deleted the azure-blob-storage-support branch October 3, 2024 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yp05327 @wxiaoguang @techknowlogick @KN4CK3R @GiteaBot