Skip to content

Always run fmt check in CI #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Sep 21, 2017
Merged

Always run fmt check in CI #2546

lunny merged 1 commit into from
Sep 21, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Sep 19, 2017 •
edited
Loading

Previously, make fmt-check would only run as a dependency of make test, which only runs on tag events. See also #2544.

I also removed fmt-check as a dependency of test, because I don't see why the two should be related. Let me know if I'm missing something.

@lunny lunny added this to the 1.3.0 milestone Sep 19, 2017
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 19, 2017
@ethantkoenig
Copy link
Member Author

ethantkoenig commented Sep 19, 2017

required-gofmt-version is failing in CI: We require go version 1.7 or 1.8 to format code (https://drone.gitea.io/go-gitea/gitea/715/5)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2017
@sapk
Copy link
Member

sapk commented Sep 20, 2017

LGTM. Could you rebase (this should pass tests since #2558) ?

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2017
@ethantkoenig
Copy link
Member Author

ethantkoenig commented Sep 21, 2017

@sapk Done

@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #2546 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2546   +/-   ##
=======================================
  Coverage   26.99%   26.99%           
=======================================
  Files          85       85           
  Lines       17097    17097           
=======================================
  Hits         4615     4615           
  Misses      11807    11807           
  Partials      675      675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6718ea6...e635c3b. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 21, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2017
@lunny lunny merged commit fa1cbc2 into go-gitea:master Sep 21, 2017
@ethantkoenig ethantkoenig deleted the ci/run_fmt_check branch September 25, 2017 05:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @sapk @codecov-io @lunny @tboerger