Skip to content

fix go get subpackage bug (#2584) #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 1 commit into from
Sep 23, 2017
Merged

fix go get subpackage bug (#2584) #2589

lafriks merged 1 commit into from
Sep 23, 2017

Conversation

@lunny
Copy link
Member

@lunny lunny commented Sep 23, 2017

backport from #2584

  • fix go get subpackage bug

  • merge the duplicated funtions

@lunny
fix go get subpackage bug (go-gitea#2584)
d46d846 
* fix go get subpackage bug

* merge the duplicated funtions
@lunny lunny added the type/bug label Sep 23, 2017
@lunny lunny added this to the 1.2.0 milestone Sep 23, 2017
@lafriks
Copy link
Member

lafriks commented Sep 23, 2017

LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2017
@daviian
Copy link
Member

daviian commented Sep 23, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 23, 2017
@daviian
Copy link
Member

daviian commented Sep 23, 2017

Make LG-TM work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 23, 2017
@lafriks lafriks merged commit 03ff768 into go-gitea:release/v1.2 Sep 23, 2017
@lunny lunny deleted the lunny/fix_incorrect_meta_tags2 branch October 26, 2017 15:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @lafriks @daviian @tboerger