Reduce usage of allcols on update

[lunny]

Reduce some unneccessary of AllCols on update.

[lafriks]

Test fails for this

[codecov-io]

Codecov Report

Merging #2596 into master will increase coverage by <.01%.
The diff coverage is 42.1%.

@@            Coverage Diff             @@
##           master    #2596      +/-   ##
==========================================
+ Coverage   27.31%   27.32%   +<.01%     
==========================================
  Files          86       86              
  Lines       17146    17143       -3     
==========================================
  Hits         4684     4684              
+ Misses      11784    11781       -3     
  Partials      678      678

Impacted Files	Coverage Δ
models/repo.go	13.5% <0%> (ø)	⬆️
models/ssh_key.go	10.48% <0%> (+0.09%)	⬆️
models/issue_milestone.go	60.88% <0%> (ø)	⬆️
models/pull.go	20.58% <0%> (ø)	⬆️
models/issue_user.go	65.71% <100%> (ø)	⬆️
models/org.go	69.8% <100%> (ø)	⬆️
models/repo_collaboration.go	67.52% <100%> (ø)	⬆️
models/user_mail.go	64.18% <33.33%> (ø)	⬆️
models/org_team.go	52.74% <40%> (ø)	⬆️
models/user.go	18.41% <66.66%> (-0.05%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6f16c...5ed36ba. Read the comment docs.

[lunny]

@lafriks done.

[appleboy]

LGTM

[ethantkoenig]

LGTM

Out of curiosity, what is the main benefit of only updating affected columns? Performance, or something else?

[lunny]

@ethantkoenig I think there are two reasons. One is for performance, another is to reduce the possibility of wrong updates. I remember the random avatar bug is affected by updating all the columns when login.