Skip to content

backport from v1.2 branch: add secrets for github release (#2588) #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
appleboy merged 1 commit into from
Sep 25, 2017
Merged

backport from v1.2 branch: add secrets for github release (#2588) #2598

appleboy merged 1 commit into from
Sep 25, 2017

Conversation

@appleboy
Copy link
Member

@appleboy appleboy commented Sep 25, 2017

As title. cc @lunny

@lunny
Copy link
Member

lunny commented Sep 25, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 25, 2017
@codecov-io
Copy link

codecov-io commented Sep 25, 2017

Codecov Report

Merging #2598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2598   +/-   ##
=======================================
  Coverage   27.31%   27.31%           
=======================================
  Files          86       86           
  Lines       17146    17146           
=======================================
  Hits         4684     4684           
  Misses      11784    11784           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa28de8...456c255. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Sep 25, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2017
@appleboy appleboy added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/deployment labels Sep 25, 2017
@appleboy appleboy added this to the 1.2.0 milestone Sep 25, 2017
@appleboy appleboy merged commit 6b6f16c into go-gitea:master Sep 25, 2017
@appleboy appleboy deleted the drone3333 branch September 25, 2017 03:40
@lafriks lafriks added backport/done All backports for this PR have been created backport/v1.2 labels Oct 4, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/deployment

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@appleboy @lunny @codecov-io @lafriks @tboerger