Skip to content

Fix translation upload to crowdin #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 2 commits into from
Sep 25, 2017
Merged

Fix translation upload to crowdin #2599

lafriks merged 2 commits into from
Sep 25, 2017

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Sep 25, 2017

As title

@lunny lunny added the type/bug label Sep 25, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 25, 2017
@lafriks lafriks mentioned this pull request Sep 25, 2017
Merged
@codecov-io
Copy link

codecov-io commented Sep 25, 2017 •
edited
Loading

Codecov Report

Merging #2599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2599   +/-   ##
=======================================
  Coverage   27.32%   27.32%           
=======================================
  Files          86       86           
  Lines       17143    17143           
=======================================
  Hits         4684     4684           
  Misses      11781    11781           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd55534...2ccb5b2. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2017
tboerger
tboerger reviewed Sep 25, 2017
View reviewed changes
.drone.yml Outdated
secrets: [ crowdin_key ]
project_identifier: gitea
ignore_branch: true
download: false
Copy link
Member

@tboerger tboerger Sep 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, false is the default

@lunny
Copy link
Member

lunny commented Sep 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2017
@lafriks
Copy link
Member Author

lafriks commented Sep 25, 2017

@tboerger fixed

@daviian
Copy link
Member

daviian commented Sep 25, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2017
@tboerger
Copy link
Member

tboerger commented Sep 25, 2017

But as commented on the other PR, this doesn't commit the downloaded files :(

@daviian
Copy link
Member

daviian commented Sep 25, 2017

@tboerger This PR is only fixing upload error and current build failure. So nothing to do with download anyway.

@lafriks lafriks merged commit 339d7de into go-gitea:master Sep 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tboerger tboerger tboerger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lafriks @codecov-io @lunny @daviian @tboerger