Remove redudant CheckUnit calls in router #2627
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
======================================
Coverage 27.3% 27.3%
======================================
Files 86 86
Lines 17139 17139
======================================
Hits 4680 4680
Misses 11781 11781
Partials 678 678Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lunny
requested changes
Sep 30, 2017
| // FIXME: should use different URLs but mostly same logic for comments of issue and pull reuqest. | ||
| // So they can apply their own enable/disable logic on routers. | ||
| m.Group("/issues", func() { | ||
| m.Combo("/new", repo.MustEnableIssues).Get(context.RepoRef(), repo.NewIssue). |
Member
There was a problem hiding this comment.
Seems no replacement for this removal?
Member
Author
There was a problem hiding this comment.
Handler in parent func, line 509, use context.CheckUnit(models.UnitTypeIssues)
lunny
added
the
type/refactoring
lunny
approved these changes
Sep 30, 2017
Member
|
LGTM |
tboerger
added
lgtm/need 1
Member
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, little speed improvement.