Skip to content

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Nov 27, 2017

Currently, all SQL commands, from all tests, are printed to stdout (or maybe stderr?) when a unit test fails. This is too much output (thousands of lines) to be helpful as the default; you have to scroll through a bunch of unrelated output just to see which test failed.

Now, output will only be printed if the environment variable $GITEA_UNIT_TESTS_VERBOSE is set to true.

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #2995 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   32.54%   32.53%   -0.02%     
==========================================
  Files         267      267              
  Lines       39270    39271       +1     
==========================================
- Hits        12779    12775       -4     
- Misses      24698    24702       +4     
- Partials     1793     1794       +1
Impacted Files Coverage Δ
models/unit_tests.go 87.5% <33.33%> (-2.98%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b58772...d04324b. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2017
@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 27, 2017
@techknowlogick
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2017
@lunny
Copy link
Member

lunny commented Nov 27, 2017

How about add an environment to enable that? Sometimes we need to know where is the error.

@ethantkoenig
Copy link
Member Author

@lunny Done

@lafriks lafriks merged commit 1028ef2 into go-gitea:master Nov 27, 2017
@ethantkoenig ethantkoenig deleted the tests/no_sql_output branch December 18, 2017 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants