Skip to content

Conversation

@pluehne
Copy link
Contributor

@pluehne pluehne commented Dec 13, 2017

I noticed that the spacing in the configuration file is inconsistent. Most options appear to use single spacing around the ‘=’ assignments. However, few options didn’t adhere to this format.

This makes the spacing consistent across all options.

I noticed that the spacing in the configuration file is inconsistent.
Most options appear to use single spacing around the ‘=’ assignments.
However, few options didn’t adhere to this format.

This makes the spacing consistent across all options.

Signed-off-by: Patrick Lühne <[email protected]>
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Dec 13, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 13, 2017
@lafriks
Copy link
Member

lafriks commented Dec 13, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 13, 2017
@codecov-io
Copy link

Codecov Report

Merging #3186 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage    34.7%   34.72%   +0.02%     
==========================================
  Files         276      276              
  Lines       39974    39974              
==========================================
+ Hits        13873    13881       +8     
+ Misses      24104    24099       -5     
+ Partials     1997     1994       -3
Impacted Files Coverage Δ
models/repo.go 41.47% <0%> (+0.18%) ⬆️
models/repo_indexer.go 51.94% <0%> (+0.97%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06cc74...d020141. Read the comment docs.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2017
@lafriks lafriks merged commit b6d2243 into go-gitea:master Dec 13, 2017
@pluehne pluehne deleted the patrick/fix-whitespace-in-config branch December 13, 2017 23:12
@pluehne
Copy link
Contributor Author

pluehne commented Dec 13, 2017

Thanks, @lafriks and @ethantkoenig, for reviewing this so quickly!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants