Skip to content

Fix randomly failing LFS lock tests in drone #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 1 commit into from
Jan 10, 2018
Merged

Fix randomly failing LFS lock tests in drone #3346

lafriks merged 1 commit into from
Jan 10, 2018

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Jan 10, 2018

As title

@lafriks lafriks added this to the 1.4.0 milestone Jan 10, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 10, 2018

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 10, 2018
@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6586190). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3346   +/-   ##
=========================================
  Coverage          ?   35.05%           
=========================================
  Files             ?      280           
  Lines             ?    40566           
  Branches          ?        0           
=========================================
  Hits              ?    14220           
  Misses            ?    24243           
  Partials          ?     2103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6586190...31de7fd. Read the comment docs.

@strk
Copy link
Member

strk commented Jan 10, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2018
@lafriks lafriks merged commit d8dff30 into go-gitea:master Jan 10, 2018
@lafriks lafriks deleted the fix/random_lfs_lock_test_fail branch January 10, 2018 22:10
@sapk
Copy link
Member

sapk commented Jan 12, 2018

I will have to rebase #3152 after this one this could maybe fix my problem ... 🤞

@sapk sapk mentioned this pull request Jan 16, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lafriks @thehowl @codecov-io @strk @sapk @tboerger