Skip to content

Escape repo search query #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 2 commits into from
Feb 11, 2018
Merged

Escape repo search query #3486

lafriks merged 2 commits into from
Feb 11, 2018

Conversation

@jonasfranz
Copy link
Member

@jonasfranz jonasfranz commented Feb 10, 2018

Fixes #3485 by escaping the search term.

Needs perhaps a backport to 1.3 and 1.4.

@jonasfranz
Escape search query
2970889 
Signed-off-by: Jonas Franz <[email protected]>
@codecov-io
Copy link

codecov-io commented Feb 10, 2018 •
edited
Loading

Codecov Report

Merging #3486 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3486      +/-   ##
==========================================
+ Coverage   35.67%   35.67%   +<.01%     
==========================================
  Files         281      281              
  Lines       40695    40697       +2     
==========================================
+ Hits        14518    14520       +2     
- Misses      24029    24030       +1     
+ Partials     2148     2147       -1
Impacted Files Coverage Δ
modules/templates/helper.go 49.65% <100%> (+0.34%) ⬆️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eaeb01...ef49cb6. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2018
@lafriks lafriks added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.4 labels Feb 10, 2018
@lafriks lafriks added this to the 1.5.0 milestone Feb 10, 2018
@cez81
Copy link
Contributor

cez81 commented Feb 10, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2018
This was referenced Feb 10, 2018
Merged
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 11, 2018
@lafriks lafriks merged commit 2cb4649 into go-gitea:master Feb 11, 2018
@jonasfranz jonasfranz deleted the escape-html branch February 11, 2018 20:24
@ghost ghost mentioned this pull request May 6, 2018
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Search query gets rendered as HTML

5 participants

@jonasfranz @codecov-io @cez81 @lafriks @tboerger