Fix bug when viewing the commit diff page with non-ANSI files #36149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Dec 13, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
lunny/fix_commit_diff_non-ansi
branch
from
af5e329 to
68d0253
Compare
wxiaoguang
force-pushed
the
lunny/fix_commit_diff_non-ansi
branch
from
68d0253 to
12a737e
Compare
wxiaoguang
added
backport/done
wxiaoguang
force-pushed
the
lunny/fix_commit_diff_non-ansi
branch
from
9539bf2 to
5a520d5
Compare
Contributor
|
Found a lot of legacy bugs. The minimal backport is #36150 |
lafriks
approved these changes
Dec 13, 2025
GiteaBot
added
lgtm/done
wxiaoguang
force-pushed
the
lunny/fix_commit_diff_non-ansi
branch
from
fb0705b to
b294923
Compare
wxiaoguang
force-pushed
the
lunny/fix_commit_diff_non-ansi
branch
from
ba8cc1b to
87d1fe5
Compare
wxiaoguang
approved these changes
Dec 13, 2025
wxiaoguang
added a commit
that referenced
this pull request
Dec 13, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 15, 2025
* giteaofficial/main: Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143) Enable gocheckcompilerdirectives linter (go-gitea#36156) Fix code highlighting on blame page (go-gitea#36157) Check user visibility when redirecting to a renamed user (go-gitea#36148) Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149) Refactor `FileTreeItem` type (go-gitea#36137) Fix various bugs (go-gitea#36139) Fix issue close timeline icon (go-gitea#36138) Add permissions to`files-changed` jobs (go-gitea#36142) Add explicit permissions to all actions workflows (go-gitea#36140) Bump `actions/checkout` to v6 (go-gitea#36136) Hide RSS icon when viewing a file not under a branch (go-gitea#36135) Fix SVG size calulation, only use `style` attribute (go-gitea#36133) Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 16, 2025
* origin/main: fix webAuthn insecure error view (go-gitea#36165) Some small refactors (go-gitea#36163) Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143) Enable gocheckcompilerdirectives linter (go-gitea#36156) Fix code highlighting on blame page (go-gitea#36157) Check user visibility when redirecting to a renamed user (go-gitea#36148) Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35504
Ref: #33844 (comment)