Skip to content

Remove maxlines option for file logger (#5282) #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 1 commit into from
Nov 7, 2018
Merged

Remove maxlines option for file logger (#5282) #5287

lafriks merged 1 commit into from
Nov 7, 2018

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Nov 7, 2018

Backport #5282

@lafriks lafriks added issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/miscellaneous type/changelog Adds the changelog for a new Gitea version labels Nov 7, 2018
@lafriks lafriks added this to the 1.6.0 milestone Nov 7, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 7, 2018
@lafriks lafriks mentioned this pull request Nov 7, 2018
Merged
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2018
@lafriks lafriks merged commit 464dcd1 into go-gitea:release/v1.6 Nov 7, 2018
@lafriks lafriks deleted the backport/fix/logging_mem_usage branch November 7, 2018 07:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/miscellaneous

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lafriks @techknowlogick @zeripath @bkcsoft @delvh