Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

partially fix #4002 according @rgiyf 's reference. see https://docs.gitlab.com/ee/administration/git_protocol.html

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #5520 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5520      +/-   ##
==========================================
- Coverage   37.61%   37.58%   -0.03%     
==========================================
  Files         317      318       +1     
  Lines       46835    46928      +93     
==========================================
+ Hits        17619    17640      +21     
- Misses      26712    26776      +64     
- Partials     2504     2512       +8
Impacted Files Coverage Δ
models/review.go 59.77% <0%> (-4.3%) ⬇️
models/branches.go 43.33% <0%> (-4%) ⬇️
routers/repo/issue.go 37.28% <0%> (-0.28%) ⬇️
models/org_team.go 49.3% <0%> (-0.1%) ⬇️
routers/repo/setting_protected_branch.go 40.23% <0%> (-0.04%) ⬇️
models/migrations/migrations.go 2.61% <0%> (ø) ⬆️
modules/auth/repo_form.go 39% <0%> (ø) ⬆️
models/migrations/v74.go 0% <0%> (ø)
models/pull.go 51.42% <0%> (+0.15%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64680b7...f639846. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@probwebdev
Copy link

That's a bad idea. Gitea have a custom sshd config for docker image:
https://github.com/go-gitea/gitea/blob/30ce1b183e9a1f8795be0c2a29a1dbc24a6a3eeb/docker/etc/ssh/sshd_config

@lunny
Copy link
Member Author

lunny commented Dec 11, 2018

@rgiyf right, updated.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@appleboy appleboy added the type/enhancement An improvement of existing functionality label Dec 11, 2018
@appleboy appleboy added this to the 1.7.0 milestone Dec 11, 2018
@techknowlogick techknowlogick merged commit 6e114f6 into go-gitea:master Dec 11, 2018
@lunny lunny deleted the lunny/git_protocol_2_docker branch December 12, 2018 00:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support Git wire protocol

7 participants