Skip to content

UI: Make document body a flexbox #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 5 commits into from
Feb 24, 2019
Merged

UI: Make document body a flexbox #6139

zeripath merged 5 commits into from
Feb 24, 2019

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Feb 20, 2019 •
edited
Loading

Fixes: #6118

Also got rid of @footer-margin which added 40px padding on bottom of some pages. Did that in the parent instead, so now the graph page also has some needed padding at the bottom.

@codecov-io
Copy link

codecov-io commented Feb 20, 2019 •
edited
Loading

Codecov Report

Merging #6139 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6139      +/-   ##
==========================================
- Coverage   38.88%   38.88%   -0.01%     
==========================================
  Files         354      354              
  Lines       50184    50184              
==========================================
- Hits        19516    19514       -2     
- Misses      27842    27844       +2     
  Partials     2826     2826
Impacted Files Coverage Δ
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ecc08...26260ef. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2019
@silverwind silverwind force-pushed the body-flex branch 2 times, most recently from 128cd82 to 0d46fff Compare February 20, 2019 19:06
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI type/bug labels Feb 20, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 20, 2019
@lafriks
Copy link
Member

lafriks commented Feb 21, 2019

Did you check on ie11?

@silverwind
Copy link
Member Author

silverwind commented Feb 21, 2019

Not yet, but Firefox, Chrome and Safari all look well.

@silverwind
Copy link
Member Author

silverwind commented Feb 21, 2019 •
edited
Loading

IE11 appears to affected by some kind of flexbug, not sure. Somehow flex: 1 has no effect on .full.height and the footer floats.

What's the plan for IE11? I dropped support in most of my projects, maybe we can too?

@silverwind
Copy link
Member Author

silverwind commented Feb 21, 2019

Removing flex: 1 and giving the footer a explicit height of 40px appears to solve it on IE11, so weird.

@lafriks
Copy link
Member

lafriks commented Feb 21, 2019

I think we still should support IE11 as that is latest IE version

@silverwind silverwind mentioned this pull request Feb 21, 2019
Closed
@silverwind
Copy link
Member Author

silverwind commented Feb 24, 2019 •
edited
Loading

IE 11 fixed and rebased. This should be ready to review.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2019
@zeripath zeripath merged commit 28fcbf3 into go-gitea:master Feb 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Site footer isn't fixed on commits graph page

7 participants

@silverwind @codecov-io @lafriks @sapk @techknowlogick @zeripath @GiteaBot