Skip to content

Minor cleanups, look at the specific commits #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreynering merged 7 commits into from
Nov 4, 2016
Merged

Minor cleanups, look at the specific commits #67

andreynering merged 7 commits into from
Nov 4, 2016

Conversation

@tboerger
Copy link
Member

@tboerger tboerger commented Nov 4, 2016

No description provided.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 4, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 4, 2016
@andreynering
Copy link
Contributor

andreynering commented Nov 4, 2016

LGTM

1 similar comment
@strk
Copy link
Member

strk commented Nov 4, 2016 •
edited by tboerger
Loading

LGTM

@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 2.18% (diff: 100%)

Merging #67 into master will not change coverage

@@            master       #67   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17

Powered by Codecov. Last update 4fdca02...c69abec

@codecov-io
Copy link

codecov-io commented Nov 4, 2016 •
edited
Loading

Current coverage is 2.18% (diff: 100%)

Merging #67 into master will not change coverage

@@            master       #67   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17

Powered by Codecov. Last update 6a20711...14fed21

@lunny
Copy link
Member

lunny commented Nov 4, 2016

lgtm.co is down? @tboerger

@tboerger
Copy link
Member Author

tboerger commented Nov 4, 2016

Should be switched to our own instance now.

@strk
Copy link
Member

strk commented Nov 4, 2016 •
edited by tboerger
Loading

LGTM then

@andreynering andreynering merged commit 03902bb into master Nov 4, 2016
@tboerger tboerger deleted the cleanup branch November 4, 2016 18:25
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@ethantkoenig @appleboy
Fix Windows path bug in GetCommitInfos (go-gitea#67)
a34a13d
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tboerger @andreynering @strk @codecov-io @lunny