Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 24, 2019

Reverts #8654

In fact, It has been checked on ignSignIn.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2019
@lunny
Copy link
Member Author

lunny commented Oct 24, 2019

fix #8673

@codecov-io
Copy link

Codecov Report

Merging #8675 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8675      +/-   ##
==========================================
+ Coverage   41.65%   41.67%   +0.02%     
==========================================
  Files         530      530              
  Lines       68597    68592       -5     
==========================================
+ Hits        28573    28589      +16     
+ Misses      36365    36348      -17     
+ Partials     3659     3655       -4
Impacted Files Coverage Δ
routers/api/v1/api.go 73.08% <ø> (+0.25%) ⬆️
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
modules/task/migrate.go 24.35% <0%> (-3.85%) ⬇️
models/error.go 32.08% <0%> (-1.25%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo.go 48.94% <0%> (+0.05%) ⬆️
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️
modules/migrations/gitea.go 11.77% <0%> (+1.49%) ⬆️
modules/migrations/migrate.go 22.9% <0%> (+1.67%) ⬆️
models/repo_indexer.go 70.18% <0%> (+3.63%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c63c3a...3ee28d2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2019
@zeripath zeripath merged commit 0a80164 into master Oct 24, 2019
@lunny lunny deleted the revert-8654-lunny/fix_api_login branch October 25, 2019 00:14
@zeripath zeripath modified the milestone: 1.11.0 Oct 30, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants