Refactor for issues loadattributes of a repository #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
ethantkoenig
suggested changes
Feb 19, 2017
models/issue_list.go
Outdated
| type IssueList []*Issue | ||
|
|
||
| func (issues IssueList) getRepoIDs() []int64 { | ||
| repoIDs := make([]int64, 0, len(issues)) |
Member
There was a problem hiding this comment.
I would suggest doing something like
repoIDs := make(map[int64]bool, len(issues))
for _, issue := range issues {
repoIDs[issue.RepoID] = true
}
return keys(repoIDs) // keys is a helper function (map[int64]bool) -> []int64
This is more efficient, and more concise (since the keys helper function can be shared across the getSomethingIDs functions)
Member
Author
|
This PR is depended on #987. |
tboerger
added
the
lgtm/need 2
ethantkoenig
approved these changes
Feb 20, 2017
Member
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Feb 22, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.