google: Add support for OAuth2 token exchange over mTLS #630

andyrzhao · 2023-02-22T20:07:20Z

With Context Aware Access enabled, users must use the endpoint "https://oauth2.mtls.googleapis.com/token" for token exchange. This PR adds support for runtime configuration of the OAuth2 token endpoint (as determined by the caller). If using the mTLS oauth2 endpoint, the caller will also need to specify an mTLS-enabled HTTPClient via the "context" mechanism for use by the OAuth2 transport.

Add OAuthClientTokenSource in google/google.go Add DefaultAuthorizationHandler in authhandler.go

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler. Added default_authhandler.go to provide a command line implementation for AuthorizationHandler.

…tead

Sync from upstream

…bject

Sync with upstream master

gopherbot · 2023-02-22T20:16:38Z

This PR (HEAD: d171fca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-24T00:07:24Z

Message from Shin Fan:

Patch Set 1: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-24T00:13:17Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-24T00:13:18Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-27T07:56:57Z

Message from Matthew Hickford:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-27T20:01:02Z

Message from Andy Zhao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T15:30:52Z

Message from Matthew Hickford:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T18:49:42Z

Message from Cody Oss:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T19:16:01Z

Message from Andy Zhao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T19:34:14Z

Message from Cody Oss:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

…tion via context

gopherbot · 2023-02-28T20:18:40Z

This PR (HEAD: a1f84d6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-28T20:43:21Z

Message from Matt Hickford:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T20:43:21Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T20:43:22Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-28T21:20:07Z

Message from Andy Zhao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-01T08:48:50Z

Message from Matthew Hickford:

Patch Set 3: -Code-Review

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-01T08:55:02Z

Message from Matthew Hickford:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-01T15:06:04Z

Message from Cody Oss:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-01T17:20:58Z

Message from Andy Zhao:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-02T17:40:37Z

This PR (HEAD: 07e4849) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-02T18:00:06Z

Message from Andy Zhao:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-02T18:06:26Z

Message from Andy Zhao:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-02T18:55:50Z

Message from Shin Fan:

Patch Set 4: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-02T19:01:55Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-02T19:01:56Z

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-03T12:02:43Z

Message from Matthew Hickford:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-03T12:02:44Z

Message from Matthew Hickford:

Patch Set 4: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

With Context Aware Access enabled, users must use the endpoint "https://oauth2.mtls.googleapis.com/token" for token exchange. This PR adds support for runtime configuration of the OAuth2 token endpoint (as determined by the caller). If using the mTLS oauth2 endpoint, the caller will also need to specify an mTLS-enabled HTTPClient via the "context" mechanism for use by the OAuth2 transport. Change-Id: Ic83342ec1d224d3acdabf00d863249330424fc54 GitHub-Last-Rev: 07e4849 GitHub-Pull-Request: #630 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/470396 Run-TryBot: Matthew Hickford <[email protected]> Reviewed-by: Shin Fan <[email protected]> Run-TryBot: Shin Fan <[email protected]> Reviewed-by: Matthew Hickford <[email protected]> Reviewed-by: Andy Zhao <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

gopherbot · 2023-03-03T19:00:01Z

This PR is being closed because golang.org/cl/470396 has been merged.

andyrzhao added 22 commits May 5, 2020 16:55

google: Add support for 3-legged-OAuth using OAuth Client ID

ceaa866

Add OAuthClientTokenSource in google/google.go Add DefaultAuthorizationHandler in authhandler.go

google: Make state configurable in DefaultAuthorizationHandler

04f020b

authhandler: Add support for 3-legged-OAuth

1105999

Added authhandler.go, which implements a TokenSource to support "three-legged OAuth 2.0" via a custom AuthorizationHandler. Added default_authhandler.go to provide a command line implementation for AuthorizationHandler.

authhandler: Add authhandler_test.go

cde11fb

authhandler: Update default_authhandler.go to inline handler logic

7c28922

authhandler: Rename to CmdAuthorizationHandler and add example_test.go

8a926e1

authhandler: Make authHandler the last parameter

ab12fee

authhandler: Remove CmdAuthorizationHandler and use it as example ins…

fcaf078

…tead

authhandler: Reword comment regarding state

1ae3746

authhandler: Reword comment regarding state in example

48fc036

authhandler: Remove example_test.go

ca291c5

Merge pull request #1 from golang/master

89bf8af

Sync from upstream

authhandler: Remove example_test.go

baf4632

google: Add support for TokenSourceParams, Client ID json, and JWT Su…

9b7db16

…bject

Merge pull request #2 from golang/master

debdcb4

Sync with upstream master

google: Address comments for CredentialsParams support

3a734b4

google: Address additional comments for CredentialsParams support.

eb92ab4

Merge remote-tracking branch 'upstream/master'

0127caf

authhandler: Add support for PKCE

0d1849c

authhandler: Address comments for PKCE

c1fddd2

Merge branch 'golang:master' into master

df3362d

google: Add support for OAuth2 token exchange over mTLS

d171fca

google: Remove TLSConfig injection logic in favor of HTTPClient injec…

a1f84d6

…tion via context

google: Update comment for TokenURL param

07e4849

gopherbot closed this Mar 3, 2023

google: Add support for OAuth2 token exchange over mTLS #630

google: Add support for OAuth2 token exchange over mTLS #630

Uh oh!

Conversation

andyrzhao commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Feb 22, 2023

Uh oh!

gopherbot commented Feb 24, 2023

Uh oh!

gopherbot commented Feb 24, 2023

Uh oh!

gopherbot commented Feb 24, 2023

Uh oh!

gopherbot commented Feb 27, 2023

Uh oh!

gopherbot commented Feb 27, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Feb 28, 2023

Uh oh!

gopherbot commented Mar 1, 2023

Uh oh!

gopherbot commented Mar 1, 2023

Uh oh!

gopherbot commented Mar 1, 2023

Uh oh!

gopherbot commented Mar 1, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 2, 2023

Uh oh!

gopherbot commented Mar 3, 2023

Uh oh!

gopherbot commented Mar 3, 2023

Uh oh!

gopherbot commented Mar 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andyrzhao commented Feb 22, 2023 •

edited

Loading