Skip to content

dev: refactor govet impl with slices.Contains #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldez merged 2 commits into from
Feb 9, 2024
Merged

dev: refactor govet impl with slices.Contains #4372

ldez merged 2 commits into from
Feb 9, 2024

Conversation

@alexandear
Copy link
Member

@alexandear alexandear commented Feb 9, 2024

The PR refactors govet's isAnalyzerEnabled implementation by changing to switch and using slices.Contains instead of raw for loop.

@ldez ldez self-requested a review February 9, 2024 19:01
@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Feb 9, 2024
ldez
ldez approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 7cf6cc9 into golangci:master Feb 9, 2024
@alexandear alexandear deleted the dev-refactor-govet-slices branch February 9, 2024 21:16
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldez ldez ldez approved these changes

Assignees

No one assigned

Labels

topic: cleanup Related to code, process, or doc cleanup

Projects

None yet

Milestone

v1.56

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear @ldez