chore!: Remove PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled field
#3866
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3866 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 200 200
Lines 14410 14410
=======================================
Hits 13315 13315
Misses 895 895
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@BigDadBear - we have some real challenges in this repo removing deprecated features because many users of this repo are using a wide range of versions of GitHub Enterprise which are notoriously slow to upgrade. As a result, we tend to not remove anything until we are truly sure that we are "all clear" which I don't remember ever happening in the last decade. At some point, it might be nice to take a survey and find out what our oldest version of GitHub Enterprise is that this repo is serving... but the biggest problem is that invariably not everyone who would be affected by this reads all the conversations, and I don't blame them... they just want things to work. So we are a bit stuck in this dilemma. |
gmlewis
added
the
Breaking API Change
|
@gmlewis Makes sense, definitely not an easy problem to solve! If it helps, the feature this param refers to (Copilot code review) has never been available in GitHub Enterprise and the param itself has only been in the API for the last year or so. |
|
Marked as ready for review now that the [docs](Updated API docs) have been updated to show the param removal |
That helps a lot... thank you, @BigDadBear! Would you like to resolve the merge conflicts, or would you like me to? I'm fine either way. Some like the challenge, others don't. 😂 Your call. |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @BigDadBear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
gmlewis
changed the title
PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled field
|
Haha thanks @gmlewis, but I'm happy to sort the conflicts out. Coming right up! |
|
Thank you, @stevehipwell! |
* forkstream/master: chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866) feat: Add support for `copilot_code_review` rule type (google#3857) feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856) feat: Add `advanced_search` parameter to `SearchOptions` (google#3868) fix!: Change Org usage report `Quantity` to `float64` (google#3862) build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863) build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864) build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865) feat: Implement Enterprise SCIM - Set Groups or Users (google#3858) feat: Add support for Enterprise Team APIs (google#3861) Bump go-github from v79 to v80 in /scrape (google#3855) Bump version of go-github to v80.0.0 (google#3854) feat: Add repository target to ruleset (google#3850)
3 participants
BREAKING CHANGE:
PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabledis now removed.Removing
PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabledand updating associated tests and accessors. This param was recently removed from the GitHub API in favor of a dedicated rule.Changelog, Updated API docs