Send settings on client initialization #125
Conversation
Send settings on LSP client initialization. Note jsonnet-language-server is unusual and expects configuration without a prefix. This is probably a bug in jsonnet-language-server, but this PR works with the existing code by passing through the "jsonnet" settings subtree, without the "jsonnet" prefix.
Example:
```elisp
;; .emacs
(lsp-register-custom-settings
'(("jsonnet.formatting"
;; jsonnetfmt --string-style d --comment-style s
((StringStyle . "double")
(CommentStyle . "slash")))))
```
anguslees
requested review from
jdbaldry,
julienduchesne and
zzehring
as code owners
|
|
|
@jdbaldry, leaving this one to you 😄 |
| (with-lsp-workspace workspace | ||
| (lsp--set-configuration | ||
| ;; TODO: jsonnet-language-server settings should use a prefix | ||
| (ht-get (lsp-configuration-section "jsonnet") "jsonnet")))) |
There was a problem hiding this comment.
Question
Does this introduce a dependency on ht?
Research
It is already a transitive dependency since it is required by lsp-mode (https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-mode.el#L39)
Follow up question
Does this usage mean that this package should also declare the dependency explicitly?
Initial thought
I'm not at all an expert on Emacs packages but I'd assume it's safest to add the dependency explicitly.
There was a problem hiding this comment.
If lsp-mode stops using ht here, then this code is wrong and won't work. So I don't think an explicit dependency improves anything.
There was a problem hiding this comment.
OK, thanks for checking :)
|
Also would you mind signing the CLA? |
|
Thanks for the contribution! |
4 participants
Send settings on LSP client initialization. Note jsonnet-language-server is unusual and expects configuration without a prefix. This is probably a bug in jsonnet-language-server, but this PR works with the existing code by passing through the "jsonnet" settings subtree, without the "jsonnet" prefix.
Example: