Skip to content

Conversation

@ulgens
Copy link
Collaborator

@ulgens ulgens commented Aug 16, 2022

A light intro of pre-commit for v2 branch. Replaces flake8 in CI for starters.

@ulgens
Copy link
Collaborator Author

ulgens commented Aug 16, 2022

@nikolaik @erikwrede 👋🏻

@ulgens ulgens self-assigned this Aug 16, 2022
@ulgens ulgens added the v2 label Aug 16, 2022
@ulgens ulgens changed the title Introduce pre-commit config for flake8 (v2) Introduce pre-commit config for flake8 Aug 16, 2022
@nikolaik
Copy link
Contributor

Nice gradual approach @ulgens love it!

Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ulgens ulgens merged commit 12ec3ca into v2 Aug 18, 2022
@ulgens ulgens deleted the pre-commit-setup branch August 18, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants