-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add syntax highlighting in Scala #3106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1cf8522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
awesome work @hugo-vrijswijk ! are there any other lesser known approaches to deliminating graphql strings used in scala? or does this cover most of them? I'm only aware of Sangria which seems to avoid using literal graphql document strings even for client queries, But I also have no idea where to look, haha. |
|
@hugo-vrijswijk awesome! one last thing - if you can add to the README for us, the various deliniation rules for Scala? This helps with setting some expectations and at least code examples to test until we add automated tests for syntax highlighting |
Good point, I've added it to the readme |
|
@acao bump 👀🙏 |
acao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @hugo-vrijswijk ! thanks for addressing the final docs nit. this is ready to release now, looking forward to it!
Adds syntax highlighting for graphql\gql strings in Scala
