Skip to content

Conversation

@hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented Mar 20, 2023

Adds syntax highlighting for graphql\gql strings in Scala
image

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: 1cf8522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql-syntax Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hugo-vrijswijk / name: Hugo van Rijswijk (5c6f646)

@acao
Copy link
Member

acao commented Mar 20, 2023

awesome work @hugo-vrijswijk ! are there any other lesser known approaches to deliminating graphql strings used in scala? or does this cover most of them? I'm only aware of Sangria which seems to avoid using literal graphql document strings even for client queries, But I also have no idea where to look, haha.

@hugo-vrijswijk
Copy link
Contributor Author

hugo-vrijswijk commented Mar 20, 2023

I realized I forgot 1 actually: schema""", which is how Grackle defines schemas. Sangria does support graphql strings, but I also added this with an eye to Clue for client queries. It now uses string literals (val document = """...), but a string interpolator could work very nicely for it

@acao
Copy link
Member

acao commented Mar 21, 2023

@hugo-vrijswijk awesome! one last thing - if you can add to the README for us, the various deliniation rules for Scala? This helps with setting some expectations and at least code examples to test until we add automated tests for syntax highlighting

@hugo-vrijswijk
Copy link
Contributor Author

@hugo-vrijswijk awesome! one last thing - if you can add to the README for us, the various deliniation rules for Scala? This helps with setting some expectations and at least code examples to test until we add automated tests for syntax highlighting

Good point, I've added it to the readme

@hugo-vrijswijk
Copy link
Contributor Author

@acao bump 👀🙏

Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @hugo-vrijswijk ! thanks for addressing the final docs nit. this is ready to release now, looking forward to it!

@acao acao merged commit 4069090 into graphql:main Apr 7, 2023
@acao acao mentioned this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants