[ESLint] replace .forEach with for..of
#3113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "for-of" loop is faster, as it doesn't need to execute the body function for each iteration (it's just a scope). This especially matters if the loop body is complex. sindresorhus/eslint-plugin-unicorn#1522 (comment)
also, GitHub has its own rule that does the same that unicorn plugin https://github.com/github/eslint-plugin-github/blob/main/docs/rules/array-foreach.md
I explicitly added a changeset