Skip to content

Conversation

@dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Mar 31, 2023

Enforces the use of, for example, document.body.append(div); over document.body.appendChild(div); for DOM nodes. There are some advantages of using Node#append(), like the ability to append multiple nodes and to append both DOMString and DOM node objects.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-append.md

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

⚠️ No Changeset found

Latest commit: 3137041

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimaMachina dimaMachina marked this pull request as ready for review April 1, 2023 03:06
@dimaMachina dimaMachina force-pushed the unicorn/prefer-dom-node-append branch from 7d1d43c to 3137041 Compare April 14, 2023 18:26
@dimaMachina dimaMachina merged commit 9ef55ab into graphql:main Apr 14, 2023
@dimaMachina dimaMachina deleted the unicorn/prefer-dom-node-append branch April 14, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants