[ESLint] enable promise/prefer-await-to-then for non React packages
#3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f8d1232 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Mar 31, 2023
Comment on lines
70
to
71
| iteratorReturn?.(); | ||
| return result.value; |
Collaborator
Author
There was a problem hiding this comment.
the only thing is that after refactoring to async/await we call iteratorReturn?.() before returning values, previously we did following, does it ok?
resolve(result.value);
// ensure cleanup
iteratorReturn?.();
dimaMachina
commented
Mar 31, 2023
dimaMachina
commented
Mar 31, 2023
| }; | ||
|
|
||
| this.loadProvider() | ||
| .then() |
Collaborator
Author
There was a problem hiding this comment.
I guess call .then is doing nothing
TallTed
suggested changes
Apr 3, 2023
Contributor
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Minor tweak of comment for clarity
thomasheyenbrock
approved these changes
Apr 14, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
dimaMachina
force-pushed
the
promise/prefer-await-to-then
branch
from
91333f2 to
f8d1232
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why for non-React - because it's ugly have
async IIFEinsideuseEffect