Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Apr 27, 2023

fixes: #2836

When there is no <script> tag in the file, it's ok. We will not have any graphql.
Let's not log an error in this situation.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 3dd94cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
graphql-language-service-cli Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jycouet
Copy link
Contributor Author

jycouet commented Apr 27, 2023

Do we need to bump vscode-graphql dependencies manually, or will tooling do this alone? Thx.

@acao
Copy link
Member

acao commented May 1, 2023

brilliant, thank you!

to answer your question, the lockfile will resolve new versions as long as dependencies or internal child dependencies have unpinned versions as usual! i think i had to disable esbuild bundling because we had bugs. i will take a closer look later in the week, but would love to get this out tomorrow to start the work week!

Edit: changesets also automatically bumps internal versions for us on release, such as the version of language server for vscode-graphql. Once we merge this, you'll see the change when it creates the deploy PR

@acao
Copy link
Member

acao commented May 2, 2023

I trust you've tested this locally! If you can fix the eslint issues, such as the duplicate test title, we can get this merged and released asap!

@acao acao merged commit 06d3982 into graphql:main May 3, 2023
@acao
Copy link
Member

acao commented May 3, 2023

awesome work @jycouet ! will release today

@acao acao mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lsp-server] svelte & vue issues with LSP server

2 participants