Preserve non-error values thrown from resolvers #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: feature 🚀
Member
Author
|
Need to add some basic tests. |
IvanGoncharov
force-pushed
the
pr_branch
branch
from
bce5fbc to
468f18f
Compare
Contributor
|
Similarly, as far as I can tell, in react, componentDidCatch gets a parameter of type mixed…. So…. |
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 6, 2021
* execute: fix spec section names in comments (graphql#3376) * lexer-tests: Use tildas as invalid characters (graphql#3377) * Preserve non-error values thrown from resolvers (graphql#3384) * Add support for Node17 (graphql#3386) * Update package-lock.json (graphql#3387) * Drop "eslint-plugin-istanbul" and implement as internal ESLint rule (graphql#3388) * package.json: Drop unused '@babel/eslint-parser' (graphql#3389) * Update deps (graphql#3390) * Enable '@typescript-eslint/switch-exhaustiveness-check' rule (graphql#3391) * Remove $FlowFixMe comments (graphql#3392) * typeFromAST: use exhaustive switch and remove invariant (graphql#3396) * Update doc examples to reflect the current API (graphql#3393) * Switch coverage from nyc to c8 (graphql#3398) * Update deps (graphql#3399) * expectJSON: improve readability (graphql#3400) * tests: Improve formating of strings with 'dedent' tag (graphql#3401) * ci: add check that 'package-lock.json' doesn't have conflicts (graphql#3403) * github/workflows: simplify npm cache setup (graphql#3404) * Use for '--ignore-scripts' for all `npm ci` & `npm install` (graphql#3405) * Simplify code by replacing Object.entries with Object.keys (graphql#3406) * ci: add check for unnessary duplicates in package-lock.json (graphql#3407) * update lockfile * Fix ci merge * fix package-lock file ...starting again from most current graphql-js Co-authored-by: Alex Reilly <[email protected]> Co-authored-by: Ivan Goncharov <[email protected]> Co-authored-by: Paul Serraino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3379