polish: fix switched comments in GraphQLScalarTypeConfig #4306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @hayes, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
hayes
force-pushed
the
mh--fix-scalar-config-comments
branch
from
30cd5e4 to
e9798b5
Compare
JoviDeCroock
approved these changes
Dec 2, 2024
Contributor
Author
|
@JoviDeCroock I'm still always amazed by how quickly you review my PRs |
Contributor
|
@hayes I see Hayes, I read changes, I press approve! Hope you're doing well bud 🙌 |
Contributor
Author
|
Can't complain! Hope things are good with you too. Cool seeing you so active in the graphql repo! |
yaacovCR
approved these changes
Dec 3, 2024
yaacovCR
added
the
PR: polish 💅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards. Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just trying to understand the new flows for how scalar values are represented/parsed/serialized, and noticed that the comments for a couple of these methods looked backwards.
Really hoping I am not just confused about the terminology, and that these aren't actually correct 😅