Document GHC-54540 and GHC-93557 #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinderDavid
force-pushed
the
ghc-93557-ghc-54540
branch
from
20d37c3 to
14258db
Compare
BinderDavid
force-pushed
the
ghc-93557-ghc-54540
branch
from
14258db to
f1d773f
Compare
BinderDavid
changed the title
Contributor
david-christiansen
left a comment
david-christiansen
left a comment
There was a problem hiding this comment.
A weird language nitpick, and one real suggestion
message-index/messages/GHC-54540/constructorsNotInScope/after/ConstructorsNotInScope.hs
Outdated
Show resolved
Hide resolved
message-index/messages/GHC-93557/illegalSynonymInstance/index.md
Outdated
Show resolved
Hide resolved
message-index/messages/GHC-93557/illegalSynonymInstance/index.md
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Thanks for the comments. I applied the suggested changes in one commit. |
Collaborator
Author
|
Ping @david-christiansen . If you don't complain then I will merge this tonight. I think I fixed all your remarks in the way you intended :) |
Contributor
|
Sorry I missed it! No time to look but I trust you
søn. 9. jul. 2023 10.57 skrev David Binder ***@***.***>:
… Ping @david-christiansen <https://github.com/david-christiansen> . If you
don't complain then I will merge this tonight. I think I fixed all your
remarks in the way you intended :)
—
Reply to this email directly, view it on GitHub
<#425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4FAXCRYFCX6KLXZDLDWTXPJW7ZANCNFSM6AAAAAAZBYIGPY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131