Documenting two examples for 83865; Adds order field to example headers
#436
Conversation
occurences of 83865, aimed at beginner Haskell programmers.
VictorCMiraldo
force-pushed
the
vcm/error-83865
branch
from
e615a33 to
7ee0612
Compare
|
I'm trying to address #438 as part of this PR, since this particular error is a great test case for it, but it seems like Hakyll insists in ignoring the order of the list it is given. I didn't have time to dig into Hakylls source code to check that yet. @david-christiansen, would you have an idea? |
|
I'm stuck in travel mode (flight chaos), so I'm not sure when I can look, but I will do it when I can! We sort lists all the time in the HF website code, so it should be possible. |
|
Thanks for looking into this! |
|
Thanks for the quick reply, I'll try a little longer tomorrow! Safe travels |
VictorCMiraldo
force-pushed
the
vcm/error-83865
branch
from
7ee0612 to
8162ec3
Compare
VictorCMiraldo
changed the title
8386583865; Adds order field to example headers
|
@david-christiansen turns out I was trying to sort the wrong thing, I got it working this morning! 🎉 |
david-christiansen
left a comment
david-christiansen
left a comment
There was a problem hiding this comment.
Thanks for this!
I have some minor nitpicks - what do you think?
Co-authored-by: David Thrane Christiansen <[email protected]>
|
Thank you for the suggestions and for writing them as clickable suggestions, @david-christiansen! I agree with all and have had them applied! |
BinderDavid
left a comment
BinderDavid
left a comment
There was a problem hiding this comment.
The ordering seems to work on my computer, and you adressed all the requested changes w.r.t to the wording. So this now looks good to me 👍
4 participants
That's a tricky error code, it shows up in many situations (https://gitlab.haskell.org/ghc/ghc/-/issues/23466), but at the same time it is one of the errors that beginners will hit the most. I attempted to document what I believe are the two situations where 83865 will appear first when someone is learning Haskell, so I tried to keep the examples almost trivially simple and the explanations short and concise. What do you folks think?
Closes #438