Skip to content

Document GHC-91028 #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BinderDavid merged 2 commits into from
Sep 1, 2023
Merged

Document GHC-91028 #454

BinderDavid merged 2 commits into from
Sep 1, 2023

Conversation

@david-christiansen
Copy link
Contributor

@david-christiansen david-christiansen commented Aug 23, 2023

Fixes #24
Fixes #453

Feedback on the somewhat long explanatory text is very welcome!

@david-christiansen
Copy link
Contributor Author

david-christiansen commented Aug 24, 2023

@sheaf - how does this fit with what you were looking for?

jhrcek
jhrcek approved these changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I never actually had to work with impredicativity, but the explanations make sense to me.

@sheaf
Copy link

sheaf commented Aug 29, 2023

Fantastic explanations, David. Thanks for doing this!

Is there a way to view the rendered HTML, just to check formatting etc? I couldn't find any links to rendered artifacts from the CI run.

@BinderDavid
Copy link
Collaborator

BinderDavid commented Sep 1, 2023

Fantastic explanations, David. Thanks for doing this!

Is there a way to view the rendered HTML, just to check formatting etc? I couldn't find any links to rendered artifacts from the CI run.

I could try releasing the build artefacts, but we should probably make sure that the artifacts get invalidated after some time, lest we use too much CI disk space in the long run.

BinderDavid
BinderDavid approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@BinderDavid BinderDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation is great 👍

@BinderDavid BinderDavid merged commit fa5adac into main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhrcek jhrcek jhrcek approved these changes

@BinderDavid BinderDavid BinderDavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include mention of QuickLook impredicativity in CannotUnifyWithPolytype error (91028) CannotUnifyWithPolytype -> 91028

5 participants

@david-christiansen @sheaf @BinderDavid @jhrcek